Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (scrollbar): add border radius to track #182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alex-cerlini
Copy link

@alex-cerlini alex-cerlini commented Aug 21, 2024

Descrição de PR

Adicionado uma borda redonda ao track da scrollbar para melhorar a visualização do card no dark mode.

Issue relacionado

Motivações

Informações adicionais

Após correção:
image

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for diciotech ready!

Name Link
🔨 Latest commit 9002778
🔍 Latest deploy log https://app.netlify.com/sites/diciotech/deploys/66e9e50d1e6e6e0009ca33d9
😎 Deploy Preview https://deploy-preview-182--diciotech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@levxyca levxyca self-requested a review September 12, 2024 12:26
@levxyca levxyca added the accessibility accessibility-related improvements or additions label Sep 12, 2024
@levxyca levxyca added this to the v2 milestone Sep 12, 2024
@levxyca levxyca linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Owner

@levxyca levxyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olá, Alex! Primeiramente, muito obrigada pela sua contribuição 🫱🏻‍🫲🏻

Dando uma revisada, percebi que você modificou o style.css. Como nosso projeto usa Sass, o CSS gerado é compilado a partir do código Sass, então modificar o CSS diretamente pode acabar gerando problemas, já que as mudanças seriam sobrescritas na próxima compilação.

O ideal seria fazer as alterações nos arquivos Sass (com extensão .scss ou .sass) e, depois, recompilar para atualizar o CSS. Aqui está o arquivo Sass principal que estamos usando: https://github.com/levxyca/diciotech/blob/main/assets/sass/style.sass

Você conseguiria ajustar dessa forma? Se precisar de qualquer ajuda, estou à disposição 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility accessibility-related improvements or additions
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Scrollbar dos cards com borda branca
2 participants