Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes spelling of "template" folder #360

Merged
merged 1 commit into from
May 24, 2024

Conversation

dkastl
Copy link
Contributor

@dkastl dkastl commented May 21, 2024

Proposed changes

The templeate folder name in the /setup directory should be spelled template.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update docker image version of FIWARE GE.
  • Update only documentation, not any source code.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have updated the change log (CHANGELOG.md)
  • I send this pull request to the v0.37.0-next branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

I tested the setup works as before on a fresh installation. I don't know how/where to update the changelog.

Further comments

I'm not sure, whether renaming a folder could cause issues for users, who already ran the setup. If that's the case, no problem to reject this pull request. This is just for aestetic reason. ;-)

@fisuda
Copy link
Contributor

fisuda commented May 24, 2024

Thank you for your contribution!

@fisuda fisuda merged commit c1a076e into lets-fiware:v0.37.0-next May 24, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
@dkastl dkastl deleted the fixes-template-spelling branch June 10, 2024 04:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants