Dynamic server branding support #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashod
force-pushed
the
master
branch
3 times, most recently
from
d3c1384 to
198001a
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
============================================
- Coverage 14.02% 13.18% -0.84%
- Complexity 137 152 +15
============================================
Files 17 17
Lines 699 743 +44
============================================
Hits 98 98
- Misses 601 645 +44 ☔ View full report in Codecov by Sentry. |
Ashod
force-pushed
the
master
branch
3 times, most recently
from
6285a5d to
eb4970f
Compare
The Online server product name is now dynamically pulled from the server, once a valid URL is provided. To avoids using a hard-coded name. After the initial discovery of the server capabilities, the product-name is cached. However we allow for changing the server (or, upon updating the server the product name may have been changed) by clearing the cache from the plugin settings page. Simply loading the settings page will invalidate the cache, if a URL is already set and is valid, and will pull the new name. The relevant strings displayed in the UI, including errors, have been updated to use the product name provided by the server with proper fallback.
|
@grabs please could you review this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Online server product name is now
dynamically pulled from the server, once a
valid URL is provided. After the initial
discovery of the server capabilities, the
product-name is cached.
However we allow for changing the server
(or, upon updating the server the product
name may have been changed) by clearing
the cache from the plugin settings page.
Simply loading the settings page will
invalidate the cache, if a URL is already
set and is valid, and will pull the new
name.
The relevant strings displayed in the UI
have been updated to use the product name
provided by the server with proper fallback.