Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build-args input #27

Merged

Conversation

austinletson
Copy link
Collaborator

Pass a new build-args input to lake build in the build step.

closes #15

@austinletson austinletson linked an issue May 17, 2024 that may be closed by this pull request
@austinletson
Copy link
Collaborator Author

I have tested this on a test repo. Here is the usage on the input and here is the corresponding build where lean-action ran lake build --quiet.

Copy link
Contributor

@oliver-butterley oliver-butterley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should explain that I am not an expert at all, here's just a comment that came to mind in case it might be useful.

There is a recommended way to avoid script injection in actions: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#good-practices-for-mitigating-script-injection-attacks

Probably this isn't a problem with the current code because it only takes an input that should be trusted in the repo which uses the action. Also I don't think the mathlib world is much a target. The main concern is that github sometimes automatically flags actions as security risks if it finds something which might worry users.

Anyway, I'm not so knowledgeable about this so might be talking nonsense!

action.yml Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
Co-authored-by: Oliver Butterley <[email protected]>
@austinletson
Copy link
Collaborator Author

I should explain that I am not an expert at all, here's just a comment that came to mind in case it might be useful.

There is a recommended way to avoid script injection in actions: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#good-practices-for-mitigating-script-injection-attacks

Probably this isn't a problem with the current code because it only takes an input that should be trusted in the repo which uses the action. Also I don't think the mathlib world is much a target. The main concern is that github sometimes automatically flags actions as security risks if it finds something which might worry users.

Anyway, I'm not so knowledgeable about this so might be talking nonsense!

I think this is spot on. Thanks for the the suggestion.

@austinletson austinletson merged commit aa36d3b into main May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add input to support passing parameters to lake build
2 participants