Upgrade 4.10.0 #66
Merged
Upgrade 4.10.0 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2024 12:02
The update involved replacing a few deprecated theorems with other equivalents. The biggest change was that the `Complex.ext_iff` theorem became private in MathLib 4.10, which was required for one theorem. That is temporarily solved with a local copy of `ext_iff`.
It seems that this lint check became a default with the release of 4.10.
jtristan
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update required minor adaptations to breakage and some deprecated tactics/theorems. There is a separate commit with a lint suggestion about cdot syntax.