Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lean-action in makefile.yml CI workflow #102

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

austinletson
Copy link
Contributor

@austinletson austinletson commented Aug 20, 2024

Description:

lean-action now supports the macOS runner so you can now use it in makefile.yml

License:

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

Closes #82

@austinletson
Copy link
Contributor Author

Hi @bollu. You may want to change this PR or create a new one based on what you need, but with the latest release, lean-action now supports macOS runners.

There is one thing I wanted to flag after looking at this. By default, lean-action will run lake build. Is this redundant since you also run lake build in the Makefile? Note you can still use lean-action to set up Elan without running lake build by using the auto-config: false input:

  uses: leanprover/lean-action@v1
  with:
    auto-config: false

@bollu
Copy link
Collaborator

bollu commented Aug 21, 2024

@austinletson thank you very much :) If you could add the line

 with:
    auto-config: false

to the PR, @shigoel can merge this in tomorrow ^_^

Don't run `lake build` in lean-action since future steps run this
@austinletson
Copy link
Contributor Author

@austinletson thank you very much :) If you could add the line

 with:
    auto-config: false

to the PR, @shigoel can merge this in tomorrow ^_^

Done!

@bollu
Copy link
Collaborator

bollu commented Aug 21, 2024

Thanks! @shigoel I think this is ready for "workflow approval"

@shigoel
Copy link
Collaborator

shigoel commented Aug 21, 2024

Thank you so much, @austinletson!

@shigoel shigoel merged commit 4fec93c into leanprover:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch back to using leanprover/lean-action once MacOS runner is fixed
3 participants