fix iOS builder adds export build argument check error

leanflutter · Jan 14, 2023 · df5ae20 · df5ae20
1 parent f711fad
commit df5ae20
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 7 deletions.
diff --git a/examples/hello_world/distribute_options.yaml b/examples/hello_world/distribute_options.yaml
@@ -32,6 +32,7 @@ releases:
           target: ipa
           build_args:
             export-options-plist: ios/ExportOptions.plist
+            # export-method: ad-hoc
             dart-define:
               APP_ENV: dev
       - name: linux-appimage

diff --git a/packages/flutter_app_builder/CHANGELOG.md b/packages/flutter_app_builder/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.2.8
+
+* fix iOS builder adds export build argument check error
+
 ## 0.2.7
 
 * iOS builder adds export build argument check

diff --git a/packages/flutter_app_builder/lib/src/app_builder_ios.dart b/packages/flutter_app_builder/lib/src/app_builder_ios.dart
@@ -17,7 +17,7 @@ class AppBuilderIos extends AppBuilder {
     String? target,
     required Map<String, dynamic> buildArguments,
   }) {
-    if (!buildArguments.containsKey('export-options-plist') ||
+    if (!buildArguments.containsKey('export-options-plist') &&
         !buildArguments.containsKey('export-method')) {
       throw BuildError(
         'Missing `export-options-plist` or `export-method` build argument.',

diff --git a/packages/flutter_app_builder/pubspec.yaml b/packages/flutter_app_builder/pubspec.yaml
@@ -1,6 +1,6 @@
 name: flutter_app_builder
 description: Build your Flutter app via Dart.
-version: 0.2.7
+version: 0.2.8
 homepage: https://github.com/leanflutter/flutter_distributor
 
 environment:

diff --git a/packages/flutter_distributor/CHANGELOG.md b/packages/flutter_distributor/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.2.8
+
+* fix iOS builder adds export build argument check error
+
 ## 0.2.7
 
 * Feat: Linux RPM packaging support (#101)

diff --git a/packages/flutter_distributor/lib/src/flutter_distributor.dart b/packages/flutter_distributor/lib/src/flutter_distributor.dart
@@ -164,6 +164,8 @@ class FlutterDistributor {
           } on UnsupportedError catch (error) {
             logger.warning('Warning: ${error.message}'.yellow());
             continue;
+          } catch (error) {
+            rethrow;
           }
         }
 
@@ -187,9 +189,12 @@ class FlutterDistributor {
           makeResultList.add(makeResult);
         }
       }
-    } on Error catch (error) {
+    } catch (error) {
       logger.severe(error.toString().red());
-      logger.severe(error.stackTrace.toString().red());
+      if (error is Error) {
+        logger.severe(error.stackTrace.toString().red());
+      }
+      rethrow;
     }
 
     return makeResultList;

diff --git a/packages/flutter_distributor/pubspec.lock b/packages/flutter_distributor/pubspec.lock
@@ -84,7 +84,7 @@ packages:
       path: "../flutter_app_builder"
       relative: true
     source: path
-    version: "0.2.7"
+    version: "0.2.8"
   flutter_app_packager:
     dependency: "direct main"
     description:

diff --git a/packages/flutter_distributor/pubspec.yaml b/packages/flutter_distributor/pubspec.yaml
@@ -1,6 +1,6 @@
 name: flutter_distributor
 description: A complete tool for packaging and publishing your Flutter apps.
-version: 0.2.7
+version: 0.2.8
 homepage: https://github.com/leanflutter/flutter_distributor
 
 platforms:
@@ -18,7 +18,7 @@ dependencies:
   app_package_publisher: ^0.2.5
   args: ^2.2.0
   dio: ^4.0.4
-  flutter_app_builder: ^0.2.7
+  flutter_app_builder: ^0.2.8
   flutter_app_packager: ^0.2.7
   flutter_app_publisher: ^0.2.5
   logging: ^1.0.2