Skip to content

Commit

Permalink
Removed wrong parameter keyword
Browse files Browse the repository at this point in the history
For #3978
  • Loading branch information
mwetter committed Aug 30, 2024
1 parent e952aaf commit 802534a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
9 changes: 6 additions & 3 deletions Buildings/UsersGuide/ReleaseNotes/Version_12_0_0.mo
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,15 @@ that do <b style=\"color:red\">not</b> lead to wrong simulation results, e.g.,
units are wrong or errors in documentation):
</p>
<table class=\"releaseTable\" summary=\"summary\" border=\"1\" cellspacing=\"0\" cellpadding=\"2\" style=\"border-collapse:collapse;\">
<tr><td colspan=\"2\"><b>xxx</b>
<tr><td colspan=\"2\"><b>Buildings.Controls.OBC.CDL</b>
</td>
</tr>
<tr><td valign=\"top\">xxx
<tr><td valign=\"top\">Buildings.Utilities.Math.Functions.round
</td>
<td valign=\"top\">xxx.
<td valign=\"top\">Removed wrong <code>parameter</code> declaration which causes an error in
Dymola 2025x beta1.<br/>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3978\">#3978</a>.
</td>
</tr>
</table>
Expand Down
9 changes: 8 additions & 1 deletion Buildings/Utilities/Math/Functions/round.mo
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function round "Round real number to specified digits"
output Real y "Connector of Real output signal";

protected
parameter Real fac = 10^n "Factor used for rounding";
Real fac = 10^n "Factor used for rounding";

algorithm
y := if (x>0) then floor(x*fac + 0.5)/fac else ceil(x*fac - 0.5)/fac;
Expand Down Expand Up @@ -46,6 +46,13 @@ Buildings.Controls.OBC.CDL.Reals.Round</a>.
</html>", revisions="<html>
<ul>
<li>
August 30, 2024, by Michael Wetter:<br/>
Removed wrong <code>parameter</code> declaration which causes an error in
Dymola 2025x beta1.<br/>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3978\">#3978</a>.
</li>
<li>
March 2, 2020, by Michael Wetter:<br/>
First implementation.<br/>
This is for
Expand Down

0 comments on commit 802534a

Please sign in to comment.