Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Aws api Gateway "How it works See it in Action" Component #5092

Merged
merged 93 commits into from
Nov 29, 2023
Merged

Fix Aws api Gateway "How it works See it in Action" Component #5092

merged 93 commits into from
Nov 29, 2023

Conversation

Cvr421
Copy link
Contributor

@Cvr421 Cvr421 commented Oct 31, 2023 •
edited
Loading

Description
Adding the New Meshmap Designer and visualizer screenshot in Aws api gateway operator
This PR fixes #4851

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Cvr421
Copy link
Contributor Author

Cvr421 commented Oct 31, 2023 •
edited
Loading

Hii @saurabh100ni @Rajdip019 Please review this PR . And let me know your thoughts if anything need to change.

@l5io
Copy link
Contributor

l5io commented Oct 31, 2023

🚀 Preview for commit e0ad9ec at: https://654143df3e1e553c746d9458--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

@sudhanshutech //

@leecalcote
Copy link
Member

@vishalvivekm how are you ensuring that these are not being overwritten?

@saurabh100ni
Copy link
Contributor

Please add this as your agenda in Doc to present it in the Website Meet today at 6:30 pm IST/7:00 am CT

@l5io
Copy link
Contributor

l5io commented Nov 22, 2023

🚀 Preview for commit d5f94e4 at: https://655e00e4fd1a4128ed3e6e15--layer5.netlify.app

vishalvivekm
vishalvivekm requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cvr421
Please create a aws-api-gateway-operator directory in integrations/_images/ and move all your screenshots in that. I mean doing this:

        renamed:    aws-api-Design-dark.png -> aws-api-gateway-operator/aws-api-Design-dark.png
        renamed:    aws-api-Design.png -> aws-api-gateway-operator/aws-api-Design.png
        renamed:    aws-api-visualizer-dark.png -> aws-api-gateway-operator/aws-api-visualizer-dark.png
        renamed:    aws-api-visualizer.png -> aws-api-gateway-operator/aws-api-visualizer.png

@github-actions github-actions bot added the area/blog New posts or new blog functionality label Nov 24, 2023
@Cvr421
Copy link
Contributor Author

Cvr421 commented Nov 24, 2023 •
edited
Loading

@vishalvivekm I have made the changes requested by you . Please review
And there are other commits is also merged with this branch i think. Should i need to do something for this OR it is ok

@l5io
Copy link
Contributor

l5io commented Nov 24, 2023

🚀 Preview for commit bb4d5af at: https://6560c828cc5ae73d037d8df3--layer5.netlify.app

@github-actions github-actions bot removed the area/blog New posts or new blog functionality label Nov 24, 2023
@l5io
Copy link
Contributor

l5io commented Nov 24, 2023

🚀 Preview for commit 7764023 at: https://6560df741fd7770b2f12abcd--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@vishalvivekm I have made the changes requested by you . Please review And there are other commits is also merged with this branch i think. Should i need to do something for this OR it is ok

@Cvr421 signoff is missing. The changes are ready except the missing DCO. Please fix it.

vivekBoii and others added 14 commits November 25, 2023 20:51
@vivekBoii @Cvr421
fix typo error in CONTRIBUTING.md
4a917aa 
Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@Cvr421
Adding the Screenshot of Meshmap
5957031 
Signed-off-by: Cvr421 <[email protected]>
@theBeginner86 @Cvr421
Revert "[workflow] Update Community Member Workflow Webhook"
56a6609 
Signed-off-by: Cvr421 <[email protected]>
@iArchitSharma @Cvr421
autoFocus added on Search bar
9ad6322 
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@iArchitSharma @Cvr421
Docs link added to Header and footer
7746b88 
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@AbiodunVlad @Cvr421
meta descriptions for service mesh patterns and layer5&hashicoop
1e68d71 
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@AbiodunVlad @Cvr421
I added description to the templates/news-single.js file
b4be560 
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@AbiodunVlad @Cvr421
description prop added in news-single.js
cebd976 
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@AbiodunVlad @Cvr421
I put the meta description for layer5 and hashicorp in the right place.
0d61c70 
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@AbiodunVlad @Cvr421
meta description for istio-up-and-running
b460db2 
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@AbiodunVlad @Cvr421
fixed duplicate subscribe to news letter on blog page
3e04bbd 
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@AbiodunVlad @Cvr421
duplicate newsletter fixed
724aaaa 
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@leecalcote @Cvr421
make
d7a0724 
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@leecalcote @Cvr421
revert
5772dc6 
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
vishalvivekm and others added 6 commits November 25, 2023 21:08
@vishalvivekm @Cvr421
move-screenshots-to-corresponding-integration-directory-within-images…
b409a05 
…-dir

Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@leecalcote @Cvr421
style
da6b51a 
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@vishalvivekm @Cvr421
fix broken references in hacktoberfest-2023-post.md
15c8503 
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@leecalcote @Cvr421
[Docs] Generated documentation for Integration
b520ce2 
Signed-off-by: l5io <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@leecalcote @Cvr421
[Docs] Generated documentation for Integration
c83ba92 
Signed-off-by: l5io <[email protected]>
Signed-off-by: Cvr421 <[email protected]>
@Cvr421
Adding new directory aws-api-gateway-operator for screenshorts
717f2aa 
Signed-off-by: Cvr421 <[email protected]>
@github-actions github-actions bot added area/news A noteworthy article, event, happening area/blog New posts or new blog functionality area/community area/learn Related to /learn section area/handbook project/kanvas type/core-styls area/site-config area/ci labels Nov 25, 2023
@github-actions github-actions bot removed area/news A noteworthy article, event, happening area/blog New posts or new blog functionality area/community area/learn Related to /learn section project/kanvas type/core-styls area/site-config area/ci labels Nov 25, 2023
@l5io
Copy link
Contributor

l5io commented Nov 25, 2023

🚀 Preview for commit 59b49fd at: https://65622732faa0394a9346eccc--layer5.netlify.app

@Cvr421
Copy link
Contributor Author

Cvr421 commented Nov 25, 2023

@vishalvivekm i have added signoff and also fix the merge conflict please review .

sandramsc
sandramsc reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@sandramsc sandramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leecalcote leecalcote merged commit e450215 into layer5io:master Nov 29, 2023
4 checks passed
@leecalcote
Copy link
Member

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalvivekm vishalvivekm vishalvivekm requested changes

@sandramsc sandramsc sandramsc left review comments

Assignees
No one assigned
Labels
area/handbook project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Screenshots] AWS API Gateway Operator under 'How it Works See It in Action' section