Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning regarding PHP 8.4 support #312

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Nov 29, 2024

The underlying library PHP-CS-Fixer is currently working on PHP 8.4 compatibility (this does not include PHP 8.4 syntax specific fixers).
See the following milestone for more information:
https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/milestone/173

It is therefor not recommended to run on PHP 8.4.

This PR implements a similar approach to was PHP-CS-Fixer does:

# With Pint:
PINT_IGNORE_ENV=1 vendor/bin/pint

# With PHP-CS-Fixer:
PHP_CS_FIXER_IGNORE_ENV=1 php php-cs-fixer.phar fix /path/to/dir

https://cs.symfony.com/doc/usage.html#environment-options

@Jubeki Jubeki changed the base branch from php84 to main November 29, 2024 05:50
@Jubeki
Copy link
Contributor Author

Jubeki commented Nov 29, 2024

@crynobone what is your take on this?

And another question, what is the command for building the pint binary? (I can only find building the phar from the workflows)

@Jubeki Jubeki mentioned this pull request Nov 29, 2024
5 tasks
@taylorotwell taylorotwell merged commit 43a25d9 into laravel:main Nov 29, 2024
6 checks passed
@Jubeki Jubeki deleted the php84 branch November 29, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants