Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --staged option #302

Closed
wants to merge 2 commits into from
Closed

Conversation

utsavsomaiya
Copy link

@utsavsomaiya utsavsomaiya commented Oct 30, 2024

Why

As a developer, I often juggle multiple tasks. For example, while working on my branch xyz, I was asked to fix an urgent issue. Instead of stashing my changes, I switched branches to address it quickly. After making the fix, I wanted to run Laravel Pint and PHPStan to check for issues, but I needed to focus only on the staged changes.

Currently, there’s a --dirty flag, but I propose adding a --staged flag. This would allow us to run Pint exclusively on staged files, improving our workflow when context-switching.

alias pint-staged="vendor/bin/pint $(git diff --cached --name-only --diff-filter=ACM)"

I have created this alias to run Pint on staged files. This command lets me quickly validate staged changes without affecting uncommitted work. But after this PR merge, I will remove it from .zshrc.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@utsavsomaiya utsavsomaiya deleted the staged-flag branch October 30, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants