-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow forms to be editable i.e. load responses given a responseID #335
base: 3.x
Are you sure you want to change the base?
Conversation
Add functionality to load responses into form Set a config for editable forms - when editable, the form stays visible Add config for save button position
PR Summary
|
@@ -63,6 +63,10 @@ | |||
|
|||
'allow_design' => false, | |||
|
|||
'editable_forms' => false, | |||
|
|||
'form_action_position_tailwind_class' => 'text-center', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kind don't like this, its means have to add a config file to the tailwind css content
array. currently I recommend to publish the views and edit any needed classes. especially for the FE views.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback - personally, I think having to maintain all the views for the sake of a button position is a bit excessive. Can you think of a middle ground?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get your point
how about make it null
. by default, and add text-center
to the blade:
config('....','text-center')
and add a comment to remind the users to add the config file to tailwind css.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will also assure there is no breaking change if the user didnt update the published config file
this would work only after saving the form right? this can be an issue when there is an extension, since the extension can display some data after saving the form, but with these changes, the user wont see the details after saving the form. |
Are you able to provide an example? I currently have this working on an embedded form which also has an extension and it works fine. Note that I'm using this by embedding the form in my own view like so:
|
for example after submitting this form you will see https://demo.larazeus.com/bolt/printer-issues/printers-department I was about to suggest to ignore that option if there is an |
Add functionality to load responses into form
Set a config for editable forms - when editable, the form stays visible
Add config for save button position