fix(messages): reuse the first valid message ID for subsequent chunks #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
reviewed
Jan 23, 2025
| @@ -8564,24 +8564,6 @@ graph TD; | |||
| tags: ["c_two_chat_model"], | |||
| }, | |||
| ], | |||
| [ | |||
There was a problem hiding this comment.
were these being emitted by mistake?
There was a problem hiding this comment.
I think so? @jacoblee93 can clarify, but it doesn't make sense to emit the message twice
There was a problem hiding this comment.
cool yea def don't want to emit things twice, can you point me to the line that was causing this?
There was a problem hiding this comment.
The issue happens on when we emit the actual chunk instead of a raw message: https://github.com/langchain-ai/langgraphjs/pull/798/files?w=1#diff-fdc54140c541e7ddfea663ff6751691ca2971772df39a299c904947b27873560R127
nfcampos
previously approved these changes
Jan 23, 2025
dqbd
force-pushed
the
dqbd/messages-stream-mode-unstable
branch
from
c5f0d2f to
81a1345
Compare
nfcampos
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)