openai: disable streaming for o1 by default #29147
Merged
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:XS
dosubot
bot
added
size:S
baskaryan
approved these changes
Jan 11, 2025
dosubot
bot
added
the
lgtm
jacoblee93
reviewed
Jan 11, 2025
| def validate_disable_streaming(cls, values: Dict[str, Any]) -> Any: | ||
| """Disable streaming if n > 1.""" | ||
| model = values.get("model_name") or values.get("model") or "" | ||
| if model == "o1" and values.get("disable_streaming") is None: |
There was a problem hiding this comment.
Should this also check for like o1-2024-12-17?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently 400s https://community.openai.com/t/streaming-support-for-o1-o1-2024-12-17-resulting-in-400-unsupported-value/1085043
o1-mini and o1-preview stream fine