Add LSH implementation for vector embedding indexing #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: beidu555 <[email protected]>
Ceng23333
reviewed
Jan 8, 2025
| <groupId>io.jhdf</groupId> | ||
| <artifactId>jhdf</artifactId> | ||
| <version>0.6.10</version> | ||
| </dependency> |
Ceng23333
reviewed
Jan 8, 2025
| @@ -89,6 +89,10 @@ public void initializeWriter() throws IOException { | |||
| assert tokioRuntimeBuilder != null; | |||
| assert ioConfigBuilder != null; | |||
|
|
|||
| setOption("is_lsh","true"); | |||
There was a problem hiding this comment.
do not set option by hard-coding, pass options by configuration
Ceng23333
reviewed
Jan 8, 2025
| @@ -348,6 +367,21 @@ impl LakeSoulIOConfigBuilder { | |||
| self | |||
| } | |||
|
|
|||
| // pub fn with_nbits(mut self,mut nbits:u64) -> Self { | |||
Ceng23333
reviewed
Jan 8, 2025
rust/lakesoul-io/src/test.rs
Outdated
| @@ -0,0 +1,7 @@ | |||
| use arrow::array::BinaryArray; | |||
xuchen-plus
changed the title
Ceng23333
reviewed
Jan 8, 2025
| use arrow::compute::sort_to_indices; | ||
| use arrow::compute::SortOptions; | ||
|
|
||
| // #[test] |
| @@ -123,7 +144,32 @@ impl SyncSendableMutableLakeSoulWriter { | |||
| // for ffi callers | |||
| pub fn write_batch(&mut self, record_batch: RecordBatch) -> Result<()> { | |||
| let runtime = self.runtime.clone(); | |||
| runtime.block_on(async move { self.write_batch_async(record_batch, false).await }) | |||
| if record_batch.num_rows() == 0{ | |||
There was a problem hiding this comment.
optimize the if condition statement
Ceng23333
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.