fix(pdb-minavailable-check): ensure correct handling of 0 replicas workloads #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! We do need DCO sign-off on all commits though. |
…rkloads Signed-off-by: Erik Godding Boye <[email protected]>
erikgb
force-pushed
the
fix-pdb-minavailable-check-replicas-0
branch
from
4bab978 to
65f920d
Compare
chipzoller
approved these changes
Nov 3, 2023
erikgb
added a commit
to erikgb/policies
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Erik Godding Boye <[email protected]>
2 tasks
erikgb
added a commit
to erikgb/policies
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Erik Godding Boye <[email protected]>
chipzoller
pushed a commit
that referenced
this pull request
Nov 4, 2023
Signed-off-by: Erik Godding Boye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Slack-thread: https://kubernetes.slack.com/archives/CLGR9BJU9/p1698916081905549
Description
This PR adds another precondition to
pdb-minavailable-checkpolicy - to ensure that 0 replicas workloads are not denied by the policy. We added this policy to our clusters and experienced a lot of false-positives on workloads withreplicas: 0, and no PDBs in namespace. I think this happens because the context variable defaults to 0.Checklist