Skip to content

Commit

Permalink
update README.md to include info about the jsc branch
Browse files Browse the repository at this point in the history
  • Loading branch information
@haochenx
haochenx committed Jan 27, 2024
1 parent 4ed27ab commit bdcd5ce
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,16 @@ if: github.repository == 'kxcdev/kxc-melange-react-native-template'

This is an opt-in feature because it uses [kxcdev/ocaml-general-gha](https://github.com/kxcdev/ocaml-general-gha) instead of the official [setup-ocaml](https://github.com/ocaml/setup-ocaml).

## Random Notes

### JavaScriptCore vs Hermes Engine (on Android)

There is a branch [jsc](https://github.com/kxcdev/kxc-melange-react-native-template/tree/jsc)
that demonstrate how to disable Hermes Engine and use JavaScriptCore
as the JavaScript engine on Android.
Please note that this branch is not actively maintained
so may not be up to date when compared to the main branch.

## License
Most code is licensed under Apache License, Version 2.0 (the "License")
by the copyright holder(s) listed below.
Expand Down

1 comment on commit bdcd5ce

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅✅✅ Test result for bdcd5ce (Ref_name=main)

CI Job: https://github.com/kxcdev/kxc-melange-react-native-template/actions/runs/7676688191
Docker Image Variant: ghcr--ubuntu.22.04-ocaml.5.1.0-node.hydrogen-amd64

Test Result (collapsed) 
++ opam env
+ eval 'OPAM_SWITCH_PREFIX='\''/root/.opam/5.1.0'\'';' export 'OPAM_SWITCH_PREFIX;' 'CAML_LD_LIBRARY_PATH='\''/root/.opam/5.1.0/lib/stublibs:/root/.opam/5.1.0/lib/ocaml/stublibs:/root/.opam/5.1.0/lib/ocaml'\'';' export 'CAML_LD_LIBRARY_PATH;' 'OCAML_TOPLEVEL_PATH='\''/root/.opam/5.1.0/lib/toplevel'\'';' export 'OCAML_TOPLEVEL_PATH;' 'MANPATH='\'':/root/.opam/5.1.0/man'\'';' export 'MANPATH;' 'PATH='\''/root/.opam/5.1.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'\'';' export 'PATH;'
++ OPAM_SWITCH_PREFIX=/root/.opam/5.1.0
++ export OPAM_SWITCH_PREFIX
++ CAML_LD_LIBRARY_PATH=/root/.opam/5.1.0/lib/stublibs:/root/.opam/5.1.0/lib/ocaml/stublibs:/root/.opam/5.1.0/lib/ocaml
++ export CAML_LD_LIBRARY_PATH
++ OCAML_TOPLEVEL_PATH=/root/.opam/5.1.0/lib/toplevel
++ export OCAML_TOPLEVEL_PATH
++ MANPATH=:/root/.opam/5.1.0/man
++ export MANPATH
++ PATH=/root/.opam/5.1.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++ export PATH
+ dune runtest

Please sign in to comment.