feat(DropdownTrigger)!: Dropdown triggerでtooltipを表示できるようにする #5291
+116
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1209
概要
Dropdown menuのtrigger buttonなどにtooltipでラベル表示したい場合にDropdownMenuButtonコンポーネントをTooltipでラップするとdropdown menu contentまでラップされるためtooltipの表示・非表示を処理しているpointerenter/pointerleaveのイベントが想定通りの挙動(tooltip trigger以外の要素でもイベント発火されてしまう)にならないため、DropdownTriggerにtooltip表示できるようにprops追加し条件付きでtooltipでラップできるように修正しました
Use case
Dropdown/FilterDropdown menuのtriggerがアイコンのみの場合、操作を可視ラベルとして表示したい
変更内容
確認方法
Storybook や Chromatic で確認いただけます
プロダクト側で確認済みです