chore: InformationPanelの内部ロジックをリファクタリングする #5289
Open
+120
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-InformationPanel
branch
from
7692615 to
19857fc
Compare
commit: |
yagimushi
force-pushed
the
chore-refactoring-InformationPanel
branch
from
19857fc to
e1a7585
Compare
AtsushiM
commented
Jan 16, 2025
| title, | ||
| titleTag, | ||
| type = 'info', | ||
| togglable = false, |
There was a problem hiding this comment.
比較にしか利用されていないため、初期値代入をする必要がありませんでした
AtsushiM
commented
Jan 16, 2025
Comment on lines
-121
to
-127
| const handleClickTrigger = useCallback(() => { | ||
| if (onClickTrigger) { | ||
| onClickTrigger(active) | ||
| } else { | ||
| setActive(!active) | ||
| } | ||
| }, [active, onClickTrigger]) |
There was a problem hiding this comment.
TogglableButton内に移動しています
AtsushiM
commented
Jan 16, 2025
Comment on lines
+135
to
+165
| const styles = useMemo(() => { | ||
| const withActive = informationPanel({ | ||
| type, | ||
| active: true, | ||
| bold, | ||
| }) | ||
| const withInactive = informationPanel({ | ||
| type, | ||
| active: false, | ||
| bold, | ||
| }) | ||
|
|
||
| const wrapperProps = { className } | ||
|
|
||
| return { | ||
| active: { | ||
| wrapper: withActive.wrapper(wrapperProps), | ||
| header: withActive.header(), | ||
| heading: withActive.heading(), | ||
| togglableButton: withActive.togglableButton(), | ||
| content: withActive.content(), | ||
| }, | ||
| inactive: { | ||
| wrapper: withInactive.wrapper(wrapperProps), | ||
| header: withInactive.header(), | ||
| heading: withInactive.heading(), | ||
| togglableButton: withInactive.togglableButton(), | ||
| content: withInactive.content(), | ||
| }, | ||
| } | ||
| }, [bold, type, className]) |
There was a problem hiding this comment.
再生成する必要がないよう、active, inactiveのパターン両方を事前に生成しています
There was a problem hiding this comment.
またコンポーネントを分割する関係上、関数を渡すよりstringを渡すほうがmemo化が適切に動作する可能性が高いためこのようなロジックにしています
AtsushiM
commented
Jan 16, 2025
Comment on lines
+173
to
+175
| <MemoizedHeading tag={titleTag} id={titleId} className={currentStyles.heading} type={type}> | ||
| {title} | ||
| </MemoizedHeading> |
There was a problem hiding this comment.
Headingは再生成が必要になるパターンが少ないことが予想されるため、丸ごとmemo化しています
AtsushiM
commented
Jan 16, 2025
| suffix={active ? <FaCaretUpIcon /> : <FaCaretDownIcon />} | ||
| size="s" | ||
| onClick={handleClickTrigger} | ||
| aria-expanded={active} |
There was a problem hiding this comment.
もともとはtogglableのようなロジックでundefinedが設定される可能性がありましたが、このボタンが表示されている場合、togglableがfalsyになる場合はありえないため、調整しています
|
@Qs-F レビューできる自信なく…レビュワー差し替えました🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法