chore: InputWithTooltipの内部でのstyle属性の生成方法を整理 #5286
Open
+11
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
yagimushi
force-pushed
the
chore-refactoring-InputWithTooltip
branch
from
29e4df0 to
bc4ad22
Compare
AtsushiM
commented
Jan 15, 2025
Comment on lines
+18
to
+25
| const widthStyle = useMemo( | ||
| () => ({ | ||
| width: typeof width === 'number' ? `${width}px` : width, | ||
| }), | ||
| [width], | ||
| ) | ||
|
|
||
| const tooltipStyleProps = useMemo(() => inputWithTooltip({ className }), [className]) |
There was a problem hiding this comment.
無意味にuseMemoがまとめられていたため、個別にmemo化するようにしました。
AtsushiM
requested review from
misako0927 and
masa0527
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法