chore: PageCounterの内部処理をリファクタリングする #5276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
commented
Jan 14, 2025
| @@ -25,40 +25,51 @@ const pageCounter = tv({ base: 'shr-text-base' }) | |||
| export const PageCounter: React.FC<Props & ElementProps> = ({ | |||
| start, | |||
| end, | |||
| total = 0, | |||
| total, | |||
There was a problem hiding this comment.
初期化位置をtotalを表示するmemo化済みコンポーネントに移動しています
AtsushiM
commented
Jan 14, 2025
Comment on lines
+34
to
+39
| if (!decorators) { | ||
| return { | ||
| text: () => RANGE_SEPARATOR, | ||
| visuallyHiddenText: () => RANGE_SEPARATOR_VISUALLY_HIDDEN_TEXT, | ||
| } | ||
| } |
There was a problem hiding this comment.
decoratorsの子要素分判定する無駄を省くため、先にdecorators自体のチェックを行うようにしています
AtsushiM
commented
Jan 14, 2025
| <span>/</span> | ||
| <BoldNumber>{children}</BoldNumber> | ||
| </> | ||
| ), |
There was a problem hiding this comment.
Totalに関してはレンダリングされる可能性が低いため、memo化しています
AtsushiM
requested review from
yuzuru-akiyama and
uknmr
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法