chore: RadioButtonPanelの内部ロジックをリファクタリングする #5267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtsushiM
commented
Jan 14, 2025
| @@ -10,7 +10,7 @@ type Props = ComponentProps<typeof RadioButton> & { | |||
| as?: string | React.ComponentType<any> | |||
| } | |||
|
|
|||
| const MEANLESS_TAG_NAMES = ['div', 'span'] | |||
| const MEANLESS_TAG_NAME_REGEX = /^(div|span)$/ | |||
There was a problem hiding this comment.
配列と比較チェックするより、正規表現で一発でチェックするほうが高速のため、調整しました。
正規表現にすると読みづらくなる場合もありますが、今回は許容範囲かな、と思います
AtsushiM
changed the title
yagimushi
force-pushed
the
chore-refactoring-RadioButtonPanel
branch
from
186fa53 to
ae76d6b
Compare
yagimushi
force-pushed
the
chore-refactoring-RadioButtonPanel
branch
from
ae76d6b to
d21ea53
Compare
commit: |
AtsushiM
requested review from
misako0927 and
nabeliwo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法