-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AnchorButtonをnext/linkなどのラップされたコンポーネントに対応 #4901
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
221ac48
feat: AnchorButtonをnext/linkなどのラップされたコンポーネントに対応
masa0527 8c98f8c
Merge branch 'master' into feat/anchor-button-add-element-as-props
masa0527 a26df80
chore: reactの型定義更新に伴うエラーを修正
masa0527 b575236
chore: restored missing comments after previous fix
masa0527 fb978dc
Merge branch 'master' into feat/anchor-button-add-element-as-props
s-sasaki-0529 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { ComponentPropsWithRef, ElementType } from 'react' | ||
|
||
export type ElementRef<T extends ElementType> = ComponentPropsWithRef<T>['ref'] | ||
|
||
export type ElementRefProps<T extends ElementType> = { ref?: ElementRef<T> } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そもそもこれ本当にまだ必要なんだろうか…?
BottomFixedArea の実装見ても、primary/secondary 属性が Button と AnchorButton のどちらかをランタイムで判定するようなコードには見えないんですがわからない。
smarthr-ui/packages/smarthr-ui/src/components/BottomFixedArea/BottomFixedArea.tsx
Lines 34 to 37 in fb978dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kufu/smarthr-ui/blob/fb978dc55d1ae277031559b658e75d0f2633423b/packages/smarthr-ui/src/components/BottomFixedArea/bottomFixedAreaHelper.ts
こっちの判定で使ってるみたい
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほえー、displayName ってそういう使い方してもいいのか…。