Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TimePicker の disabled 時のテキストカラーを修正する #4880

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

oti
Copy link
Contributor

@oti oti commented Aug 28, 2024

Related URL

Overview

<TimePicker disabled />(非活性)時のテキストカラーが TEXT_BLACK のままになっている

AsIs Inputの例 Selectの例
image image (2) image (1)

What I did

対応方法は複数あったがもっとも差分がすくない、disabled:shr-text-disabled を追加することで対応しました。

AsIs ToBe
image image

Capture

@oti oti requested a review from a team as a code owner August 28, 2024 06:16
@oti oti requested review from moshisora and masa0527 and removed request for a team August 28, 2024 06:16
Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Chromatic 差分が確認できました。シンプルな修正で済んでて良きです!

@oti oti requested a review from Qs-F August 28, 2024 07:01
@oti oti merged commit 7e27441 into master Aug 28, 2024
9 checks passed
@oti oti deleted the fix/TimePicker-disabled-text-color branch August 28, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants