feat!: Dialog の位置指定を消し、スタイリングを見直し #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uknmr
requested review from
moshisora and
s-sasaki-0529
and removed request for
a team
uknmr
force-pushed
the
remove-Dialog-position
branch
from
f4d5444 to
66d77be
Compare
uknmr
force-pushed
the
remove-Dialog-position
branch
from
66d77be to
c81b121
Compare
|
@s-sasaki-0529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/SHRUI-702
Overview
ActionDialog や MessageDialog、FormDialog から絶対位置指定のための props（top / right / bottom / left）を消しました。
また、今後の構造改修やモバイル対応を見据えてスタイリング周りの記述を見直しました。
What I did
Capture