Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volume-migration: describe migration cancellation and recovery #862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

volume-migration: describe migration cancellation and recovery #862

wants to merge 1 commit into from

Conversation

alicefr
Copy link
Member

@alicefr alicefr commented Jan 10, 2025

What this PR does / why we need it:
Add the documentation for the volume migration cancellation and manual recovery.

Release note:

Document volume migration cancellation and recovery

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 10, 2025
@alicefr
Copy link
Member Author

alicefr commented Jan 10, 2025

/hold
kubevirt/kubevirt#13666 needs to be merged to be consistent

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
@alicefr
Copy link
Member Author

alicefr commented Jan 10, 2025

/cc @mhenriks

@kubevirt-bot kubevirt-bot requested a review from mhenriks January 10, 2025 12:34
@alicefr alicefr mentioned this pull request Jan 10, 2025
Merged
@alicefr alicefr force-pushed the vol-mig-recovery branch 2 times, most recently from f875616 to 13c691d Compare January 10, 2025 15:29
awels
awels reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@awels awels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good one small change

docs/storage/volume_migration.md Outdated Show resolved Hide resolved
vladikr
vladikr reviewed Jan 14, 2025
View reviewed changes
docs/storage/volume_migration.md Outdated
NAME READY STATUS RESTARTS AGE
virt-launcher-vm-dv-mlc6q 0/3 Completed 0 8m48s
```
3. Libvirt reported the migration as succeded by switching the domain from paused to running in the target virt-launcher pod:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you also planning to add an example with a TargetNodeDomainReadyTimestamp or do you think this is enough information for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm actually planning to replace the logs with that, it is much more stable

@vladikr
Copy link
Member

vladikr commented Jan 14, 2025

/approve
Look great.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@alicefr alicefr force-pushed the vol-mig-recovery branch 2 times, most recently from 5b83b2b to 0379e97 Compare January 14, 2025 08:39
@alicefr
Copy link
Member Author

alicefr commented Jan 14, 2025

Fixed the last feedback
/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels awels left review comments

@vladikr vladikr vladikr left review comments

@akalenyu akalenyu Awaiting requested review from akalenyu

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alicefr @vladikr @kubevirt-bot @awels