cluster-up, kind: all to exec command via ssh.sh and add port mapping for kind cluster #1344
Conversation
Currently cluster-up/ssh.sh not only allow to ssh into the cluster, but also allow to exec command directly via the script, make it works on kind cluster Signed-off-by: howard zhang <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
There was a problem hiding this comment.
thanks @zhlhahaha - looks good to me - just a couple of comments inline.
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: howard zhang <[email protected]>
|
/test check-up-kind-sriov |
1 similar comment
|
/test check-up-kind-sriov |
|
@zhlhahaha: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @brianmcarey , I do not think the failure of |
Hi @zhlhahaha - yes you are right there looks to be an issue with the SRIOV lane itself. /override check-up-kind-sriov |
|
@brianmcarey: Overrode contexts on behalf of brianmcarey: check-up-kind-sriov In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
[6c7e367 cluster-up, kind: all to exec command via ssh.sh and add port mapping for kind cluster](kubevirt/kubevirtci#1344) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[6c7e367 cluster-up, kind: all to exec command via ssh.sh and add port mapping for kind cluster](kubevirt/kubevirtci#1344) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[6c7e367 cluster-up, kind: all to exec command via ssh.sh and add port mapping for kind cluster](kubevirt/kubevirtci#1344) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):kubevirt/containerized-data-importer#3466
Release note: