Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more IOPS to help raft latencies #17233

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Add more IOPS to help raft latencies #17233

merged 2 commits into from
Jan 26, 2025
+13 −0

Conversation

hakuna-matatah
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@k8s-ci-robot k8s-ci-robot requested review from dims and hakman January 23, 2025 01:58
@hakuna-matatah hakuna-matatah changed the title [WIP] add more IOPS to help disk latencies [WIP] add more IOPS to help raft latencies Jan 23, 2025
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/retest

@hakman
Copy link
Member

hakman commented Jan 23, 2025

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author 

Error: error building tasks: volumeIops to volumeSize ratio must be lower than 500. For a.etcd-main.e2e-fa029a0ba8-a2033.test-cncf-aws.k8s.io ratio is 800.00

Need to increase volume size as well.

@hakuna-matatah
add more IOPS to help disk latencies
a8ea013 
Update tests/e2e/scenarios/scalability/run-test.sh
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

1 similar comment
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

1 similar comment
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakuna-matatah hakuna-matatah changed the title [WIP] add more IOPS to help raft latencies Add more IOPS to help raft latencies Jan 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2025
@hakuna-matatah
Copy link
Contributor Author

/test pull-kops-kubernetes-e2e-ubuntu-gce-build pull-kops-e2e-k8s-gce-cilium pull-kops-e2e-k8s-aws-amazonvpc

@hakuna-matatah
Copy link
Contributor Author

/test pull-kops-e2e-k8s-aws-calico

@dims
Copy link
Member

dims commented Jan 25, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2025
@dims
Copy link
Member

dims commented Jan 25, 2025

/retest

@dims
Copy link
Member

dims commented Jan 25, 2025

/test pull-kops-e2e-k8s-aws-amazonvpc

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot
Copy link
Contributor

@hakuna-matatah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-kops-aws-scale-amazonvpc-using-cl2 c8010fb link false /test presubmit-kops-aws-scale-amazonvpc-using-cl2
pull-kops-kubernetes-e2e-ubuntu-gce-build c8010fb link false /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 8d354fa into kubernetes:master Jan 26, 2025
24 of 26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@dims dims Awaiting requested review from dims

@hakman hakman Awaiting requested review from hakman

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@hakuna-matatah @hakman @dims @k8s-ci-robot @k8s-triage-robot @rifelpet