-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] Add extraEnv support on cinder-csi-plugin and manila-csi-plugin helm charts #2613
[cinder-csi-plugin] Add extraEnv support on cinder-csi-plugin and manila-csi-plugin helm charts #2613
Conversation
Welcome @pli01! |
Hi @pli01. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: pli01 <[email protected]>
Signed-off-by: pli01 <[email protected]>
b971b45
to
3605770
Compare
/ok-to-test Looks like this could be useful for the Manila CSI charts too? Could you add it there as well? |
Thanks for the approval. |
Added for manila |
Looks good, just why do you comment out Manila's values.yaml, but not Cinder's? |
mistake it s now fixed |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Add
extraEnv
support on the cinder-csi-plugin helm chart.Which issue this PR fixes(if applicable):
Special notes for reviewers:
One example use case of extraEnv: In some of our private customer cloud, cinder-csi-plugin must access the openstack API endpoint with following env variable
http_proxy, https_proxy, no_proxy
.Release note: