Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] Add extraEnv support on cinder-csi-plugin and manila-csi-plugin helm charts #2613

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

pli01
Copy link
Contributor

@pli01 pli01 commented Jun 2, 2024

What this PR does / why we need it:

Add extraEnv support on the cinder-csi-plugin helm chart.

Which issue this PR fixes(if applicable):

Special notes for reviewers:

One example use case of extraEnv: In some of our private customer cloud, cinder-csi-plugin must access the openstack API endpoint with following env variable http_proxy, https_proxy, no_proxy.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @pli01!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @pli01. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from kayrus and mdbooth June 2, 2024 11:23
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2024
@pli01 pli01 force-pushed the add-cinder-csi-helm-extra-env branch from b971b45 to 3605770 Compare June 2, 2024 21:54
@dulek
Copy link
Contributor

dulek commented Jun 6, 2024

/ok-to-test

Looks like this could be useful for the Manila CSI charts too? Could you add it there as well?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2024
@pli01
Copy link
Contributor Author

pli01 commented Jun 6, 2024

Looks like this could be useful for the Manila CSI charts too? Could you add it there as well?

Thanks for the approval.
Yes, i will try to add here also the modification for Manila CSI charts.

@pli01 pli01 changed the title [cinder-csi-plugin] Add extraEnv support on the cinder-csi-plugin helm chart [cinder-csi-plugin] Add extraEnv support on cinder-csi-plugin and manila-csi-plugin helm charts Jun 6, 2024
@pli01
Copy link
Contributor Author

pli01 commented Jun 6, 2024

Added for manila
@dulek , Is that okay with you ?

@dulek
Copy link
Contributor

dulek commented Jun 6, 2024

Looks good, just why do you comment out Manila's values.yaml, but not Cinder's?

@pli01
Copy link
Contributor Author

pli01 commented Jun 6, 2024

Looks good, just why do you comment out Manila's values.yaml, but not Cinder's?

mistake

it s now fixed

@jichenjc
Copy link
Contributor

jichenjc commented Jun 7, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
@dulek
Copy link
Contributor

dulek commented Jun 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 76d7608 into kubernetes:master Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants