Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] add dnsPolicy feature #2594

Merged
merged 1 commit into from
May 15, 2024
Merged

[occm] add dnsPolicy feature #2594

merged 1 commit into from
May 15, 2024

Conversation

xinity
Copy link
Contributor

@xinity xinity commented May 13, 2024 •
edited
Loading

What this PR does / why we need it:
this PR adds dnsPolicy configuration to occm which should be changed if deployed in a cluster with a custom coredns configuration like internal dns domain.
Which issue this PR fixes(if applicable):
fixes #2592

Special notes for reviewers:

Release note:

[openstack-cloud-controller-manager] Add dnsPolicy configuration to manifests and charts

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 13, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sevensphereio / name: sevensphereio (154e50f)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @xinity!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @xinity. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from jichenjc and mdbooth May 13, 2024 20:35
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2024
@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 14, 2024
@xinity xinity force-pushed the xinity-occm-dns-policy branch 2 times, most recently from 1d7591f to 5ccc55b Compare May 14, 2024 06:43
dulek
dulek requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some remarks inline.

charts/openstack-cloud-controller-manager/templates/daemonset.yaml Outdated Show resolved Hide resolved
charts/openstack-cloud-controller-manager/values.yaml Outdated Show resolved Hide resolved
charts/openstack-cloud-controller-manager/values.yaml Outdated Show resolved Hide resolved
@xinity xinity force-pushed the xinity-occm-dns-policy branch from 5ccc55b to 154e50f Compare May 14, 2024 14:17
@dulek
Copy link
Contributor

dulek commented May 14, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 771818c into kubernetes:master May 15, 2024
5 checks passed
@ericgraf ericgraf mentioned this pull request May 31, 2024
Closed
yankcrime added a commit to unikorn-cloud/kubernetes that referenced this pull request Jun 21, 2024
@yankcrime
[NS-81] Bump OpenStack CCM to latest release
e62241a 
Upgrade the CCM to the latest release, commensurate with the current
version of Kubernetes.

Explicitly set the value for `dnsPolicy` to skirt this issue:
kubernetes/cloud-provider-openstack#2594
@yankcrime yankcrime mentioned this pull request Jun 21, 2024
Merged
yankcrime added a commit to unikorn-cloud/kubernetes that referenced this pull request Jun 21, 2024
@yankcrime
[NS-81] Bump OpenStack CCM to latest release
2bdcf8f 
Upgrade the CCM to the latest release, commensurate with the current
version of Kubernetes.

Explicitly set the value for `dnsPolicy` to skirt this issue:
kubernetes/cloud-provider-openstack#2594
yankcrime added a commit to unikorn-cloud/kubernetes that referenced this pull request Jun 21, 2024
@yankcrime
[NS-81] Bump OpenStack CCM and CSI to latest release
051fb82 
Upgrade the CCM and the Cinder CSI driver to the latest release,
commensurate with the current version of Kubernetes.

Explicitly set the value for `dnsPolicy` to skirt this issue:
kubernetes/cloud-provider-openstack#2594
yankcrime added a commit to unikorn-cloud/kubernetes that referenced this pull request Jun 28, 2024
@yankcrime
[NS-81] Bump OpenStack CCM and CSI to latest release
017e948 
Upgrade the CCM and the Cinder CSI driver to the latest release,
commensurate with the current version of Kubernetes.

Explicitly set the value for `dnsPolicy` to skirt this issue:
kubernetes/cloud-provider-openstack#2594
spjmurray pushed a commit to unikorn-cloud/kubernetes that referenced this pull request Jun 28, 2024
@yankcrime
[NS-81] Bump OpenStack CCM and CSI to latest release (#100)
2c40290 
Upgrade the CCM and the Cinder CSI driver to the latest release,
commensurate with the current version of Kubernetes.

Explicitly set the value for `dnsPolicy` to skirt this issue:
kubernetes/cloud-provider-openstack#2594
@zetaab zetaab mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawcykca pawcykca pawcykca left review comments

@dulek dulek dulek requested changes

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[occm] doesn't rely on coredns configuration to do dns resolution
6 participants
@xinity @k8s-ci-robot @jichenjc @dulek @pawcykca @sevensphereio