[cinder-csi-plugin] define availability zone for snapshot backup #2569
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
| backup = &backups[0] | ||
| // since backup.VolumeID is not part of ListBackups response | ||
| // we need fetch single backup to get the full object. | ||
| backup, err = cs.Cloud.GetBackupByID(backups[0].ID) |
There was a problem hiding this comment.
ListBackups filters by Name and the response is https://docs.openstack.org/api-ref/block-storage/v3/index.html#list-backups-for-project
There is another list backups api that will response all of the details https://docs.openstack.org/api-ref/block-storage/v3/index.html#list-backups-with-detail However, that will not support filter by Name. So I think fetching this single backup by id is enough for now.
|
cc @dulek I have now verified the snapshot backup feature. Without changes in this PR the whole feature does not work properly. Its missing Availability zone support and restoring the data itself is broken currently for everyone. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@dulek I would like to see this in 1.30 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it: Original snapshot backup support was added in #2480. However, it assumes that openstack volume backup zones will match to cinder zones. In our case, that is not true. We have different names for cinder zones than backup zone. That is why availability zone parameter is needed.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: