Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #2488

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix some typos #2488

merged 1 commit into from
Dec 13, 2023

Conversation

jeffyjf
Copy link
Contributor

@jeffyjf jeffyjf commented Dec 2, 2023

What this PR does / why we need it:

I found some typos by vsocde spellchecker plugin.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jeffyjf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2023
@jeffyjf jeffyjf force-pushed the fix-typos branch 3 times, most recently from 2f0f432 to 1bbfc9f Compare December 2, 2023 08:12
@jeffyjf
Fix some typos
ef162df 
Fix some typos that I found with vsocde spellchecker plugin[1].

[1] https://github.com/streetsidesoftware/vscode-spell-checker
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2023
@jeffyjf
Copy link
Contributor Author

jeffyjf commented Dec 4, 2023

cc @dulek asking for review.

@dulek
Copy link
Contributor

dulek commented Dec 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2023
dulek
dulek approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much @jeffyjf! I'll leave setting the other label to another member of the team, I'd like another opinion on changing user-facing messages.
/approve

pkg/csi/cinder/controllerserver.go
Comment on lines -533 to +540
return nil, status.Errorf(codes.NotFound, "ValidateVolumeCapabiltites Volume %s not found", volumeID)
return nil, status.Errorf(codes.NotFound, "ValidateVolumeCapabilities Volume %s not found", volumeID)
}
return nil, status.Errorf(codes.Internal, "ValidateVolumeCapabiltites %v", err)
return nil, status.Errorf(codes.Internal, "ValidateVolumeCapabilities %v", err)
}

for _, cap := range reqVolCap {
if cap.GetAccessMode().GetMode() != cs.Driver.vcap[0].Mode {
return &csi.ValidateVolumeCapabilitiesResponse{Message: "Requested Volume Capabilty not supported"}, nil
return &csi.ValidateVolumeCapabilitiesResponse{Message: "Requested Volume Capability not supported"}, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three can affect the users, but if they depend on message contents, then they probably deserve it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

pkg/csi/cinder/nodeserver.go
@@ -317,7 +317,7 @@ func nodeUnpublishEphemeral(req *csi.NodeUnpublishVolumeRequest, ns *nodeServer,
if len(vol.Attachments) > 0 {
instanceID = vol.Attachments[0].ServerID
} else {
return nil, status.Error(codes.FailedPrecondition, "Volume attachement not found in request")
return nil, status.Error(codes.FailedPrecondition, "Volume attachment not found in request")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@jeffyjf
Copy link
Contributor Author

jeffyjf commented Dec 13, 2023

/retest

@jeffyjf
Copy link
Contributor Author

jeffyjf commented Dec 13, 2023

/test openstack-cloud-csi-cinder-e2e-test

@jeffyjf
Copy link
Contributor Author

jeffyjf commented Dec 13, 2023

This is great, thank you so much @jeffyjf! I'll leave setting the other label to another member of the team, I'd like another opinion on changing user-facing messages.

In my option, they should be corrected. Due to some log system or monitor system maybe use regular expression to filter the results, in this case incorrect spelling will result in incorrect result.

@jeffyjf
Copy link
Contributor Author

jeffyjf commented Dec 13, 2023

@jichenjc @kayrus @zetaab asking for review
Thanks in advnace

kayrus
kayrus approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/csi/cinder/openstack/openstack_snapshots.go
@@ -173,7 +173,7 @@ func (os *OpenStack) WaitSnapshotReady(snapshotID string) error {
})

if wait.Interrupted(err) {
err = fmt.Errorf("Timeout, Snapshot %s is still not Ready %v", snapshotID, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why don't we just return here

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 34f5ea5 into kubernetes:master Dec 13, 2023
11 checks passed
@kayrus kayrus mentioned this pull request Dec 13, 2023
Closed
This was referenced Dec 13, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayrus kayrus kayrus approved these changes

@dulek dulek dulek approved these changes

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

@openstacker openstacker Awaiting requested review from openstacker

Assignees

@kayrus kayrus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffyjf @k8s-ci-robot @dulek @kayrus