-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] update CSI version #2478
Conversation
142a5b8
to
4da7e6a
Compare
perhaps we should wait until all docker images are working from registry? |
ok, will give a try 2.9.1=>2.9.2 just a CVE update, not some functional , anyway , wait for a few days and let's see :) |
waiting for kubernetes-csi/node-driver-registrar#359 |
07e5caa
to
56b35f6
Compare
56b35f6
to
d64cd51
Compare
@zetaab updated, please help take a look, thanks~ |
@jichenjc can you rebase on latest master? It looks like this PR includes full merge with the latest changes and it's hard to read the actual changes. |
@kayrus I can see only 4 files changes with 14 lines :) |
@jichenjc hm, probably github somehow cached the diff. Now it looks like it should. Do you need my lgtm? |
do we need to update the spec versions here as well? $ grep -ri specVersion pkg/
pkg/csi/manila/driver.go: specVersion = "1.8.0"
pkg/csi/manila/driver.go: klog.Info("CSI spec version: ", specVersion)
pkg/csi/cinder/driver.go: specVersion = "1.8.0"
pkg/csi/cinder/driver.go: klog.Info("CSI Spec version: ", specVersion)
$ grep -r 1.8.0 docs
docs/cinder-csi-plugin/using-cinder-csi-plugin.md:This plugin is compatible with CSI v1.8.0 I'm not sure if this is somehow relevant... |
need check more on the spec itself ,e.g whether we really |
@jichenjc let's skip the spec topic for a while, since this variable is only informational. |
@kayrus ok, please help lgtm this if ok to you, thanks |
/lgtm |
@zetaab help to approve this ? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
um... why the merge is not auto-complete? curious |
/retest |
What this PR does / why we need it:
update CSI cinder version
note that csi-node-driver-registrar:v2.9.2 is not ready yet
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: