Invoke node Update only for providerID changes

kubernetes-sigs · Jan 30, 2020 · e587dc5 · e587dc5
1 parent 5089225
commit e587dc5
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/pkg/csi/service/cns/nodes.go b/pkg/csi/service/cns/nodes.go
@@ -58,7 +58,20 @@ func (nodes *Nodes) nodeAdd(obj interface{}) {
 }
 
 func (nodes *Nodes) nodeUpdate(oldObj interface{}, newObj interface{}) {
-	nodes.nodeRegister(newObj)
+	newNode, ok := newObj.(*v1.Node)
+	if !ok {
+		klog.Warningf("nodeUpdate: unrecognized object newObj %[1]T%+[1]v", newObj)
+		return
+	}
+	oldNode, ok := oldObj.(*v1.Node)
+	if !ok {
+		klog.Warningf("nodeUpdate: unrecognized object oldObj %[1]T%+[1]v", oldObj)
+		return
+	}
+	if oldNode.Spec.ProviderID != newNode.Spec.ProviderID {
+		klog.V(2).Infof("nodeUpdate: Observed ProviderID change from %q to %q for the node: %q", oldNode.Spec.ProviderID, newNode.Spec.ProviderID, newNode.Name)
+		nodes.nodeRegister(newObj)
+	}
 }
 
 func (nodes *Nodes) nodeRegister(obj interface{}) {