Pass WindowsContainerResources in UpdateContainerResources call #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
cc @jsturtevant @marosset @aravindhp @dims could you please take a look when you have a chance? Thanks! |
This commit fixes the regression introduced by commit 1616f25 by passing WindowsContainerResources information in UpdateContainerResources call. Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
force-pushed
the
pass-windows-container-resources
branch
from
1593b34 to
80a8cdc
Compare
k8s-ci-robot
removed
the
needs-rebase
|
cc @msscotb |
|
/retest |
jsturtevant
approved these changes
Jan 9, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsturtevant, kiashok The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass WindowsContainerResources in UpdateContainerResources call
This was regressed in commit 1616f25 for crictl.exe update command on windows.
1616f25
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a regression introduced by a commit roughly 3 years ago.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE