Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] 📖 docs: document tagging the test go module #2881

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[release-1.9] 📖 docs: document tagging the test go module #2881

merged 2 commits into from
Apr 5, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2761

/assign chrischdi

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 5, 2024
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2024
@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2fe6dbd4eace929389911e07dc1c05736d12f866

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@chrischdi
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from chrischdi April 5, 2024 14:08
@chrischdi
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.07%. Comparing base (ef99bf9) to head (09486f7).
Report is 1 commits behind head on release-1.9.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.9    #2881      +/-   ##
===============================================
+ Coverage        63.97%   64.07%   +0.09%     
===============================================
  Files              159      159              
  Lines             9313     9313              
===============================================
+ Hits              5958     5967       +9     
+ Misses            2894     2888       -6     
+ Partials           461      458       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi
Copy link
Member

/override pull-cluster-api-provider-vsphere-verify-release-1-9

Docs only change

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Overrode contexts on behalf of chrischdi: pull-cluster-api-provider-vsphere-verify-release-1-9

In response to this:

/override pull-cluster-api-provider-vsphere-verify-release-1-9

Docs only change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: db04545550dd05a57d665a0de09e0a62290656bf

@k8s-ci-robot k8s-ci-robot merged commit e50b9e2 into kubernetes-sigs:release-1.9 Apr 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@MaxRink MaxRink Awaiting requested review from MaxRink

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@k8s-infra-cherrypick-robot @chrischdi @k8s-ci-robot