Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor jwt parser code and add uts for setProviderID #2144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor jwt parser code and add uts for setProviderID #2144

wants to merge 1 commit into from

Conversation

arshadd-b
Copy link
Contributor

What this PR does / why we need it:
This PR refactor the code to parse token and get accountID and adds the coverage for setProviderID function
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #2128

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

 refactor jwt parser code and add uts for setProviderID

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arshadd-b
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 87ac1eb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67935a3347c8df0008b8fdb6
😎 Deploy Preview https://deploy-preview-2144--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Karthik-K-N
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2025
@Karthik-K-N
Copy link
Contributor

@Prajyot-Parab ^^

@Prajyot-Parab
Copy link
Contributor

/hold lets get #2122 merged first
meanwhile will review this PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@Prajyot-Parab
Copy link
Contributor

@arshadd-b I think we should split the changes in 2 different commits as it will be easier to interpret.

  1. refactor jwt parser code
  2. add uts for setProviderID

@Karthik-K-N your thoughts?

@Karthik-K-N
Copy link
Contributor

@arshadd-b I think we should split the changes in 2 different commits as it will be easier to interpret.

1. refactor jwt parser code

2. add uts for setProviderID

@Karthik-K-N your thoughts?

Yeah, That would be better

mkumatag
mkumatag requested changes Jan 24, 2025
View reviewed changes
pkg/cloud/services/utils/accounts.go
@@ -55,10 +56,10 @@ func GetAccount(auth core.Authenticator) (string, error) {
}

// GetAccountID will parse and returns user cloud account ID.
func GetAccountID() (string, error) {
func GetAccountID(jwtParser parser.TokenParser) (string, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the need of jwtParser here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag requested changes

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees
No one assigned
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arshadd-b @k8s-ci-robot @Karthik-K-N @Prajyot-Parab @mkumatag