Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test coverage of SetProviderID function in machine.go #2128

Open
Prajyot-Parab opened this issue Jan 9, 2025 · 2 comments
Open

Enhance test coverage of SetProviderID function in machine.go #2128

Prajyot-Parab opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Prajyot-Parab
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

  • Enhance test coverage of SetProviderID function in machine.go

Ref - https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/cloud/scope/machine.go#L1077-L1085

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

  • This is required to fix the test case failures reported post removal of deprecated v1 provider id format.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jan 9, 2025
@Prajyot-Parab
Copy link
Contributor Author

/cc @Karthik-K-N

@arshadd-b
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants