disk: wait for device to appear on attach #1307
Conversation
Even after OpenAPI returns Attached status, the device may not be available in OS immediately. We wait for 10s to reduce noisy error events. Reduce flakes in csi-sanity, which will not retry.
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
| @@ -234,7 +234,7 @@ func (ad *DiskAttachDetach) attachDisk(ctx context.Context, diskID, nodeID strin | |||
|
|
|||
| // step 5: diff device with previous files under /dev | |||
| if fromNode { | |||
| device, err := DefaultDeviceManager.GetDeviceByVolumeID(diskID) | |||
| device, err := DefaultDeviceManager.WaitDevice(ctx, diskID) | |||
There was a problem hiding this comment.
Wait 10 seconds for each disk without a series id?
There was a problem hiding this comment.
Better to add logs to record err message
There was a problem hiding this comment.
Wait 10 seconds for each disk without a series id?
Currently yes. This can be resolved by #1199 , which explicitly distinguishes disks with or without serial number.
What type of PR is this?
/kind cleanup
/kind flake
What this PR does / why we need it:
Even after OpenAPI returns Attached status, the device may not be available in OS immediately. We wait for 10s to reduce noisy error events.
Which issue(s) this PR fixes:
Fixes #
Reduce flakes in csi-sanity, which will not retry.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: