Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New addons v1beta3 API #3248

Merged
merged 14 commits into from
Aug 12, 2024
Merged

New addons v1beta3 API #3248

merged 14 commits into from
Aug 12, 2024

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 20, 2024 •
edited
Loading

What this PR does / why we need it:
This is a replacement for #3202

What type of PR is this?
/kind feature
/kind api-change

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

New addons v1beta3 API

Documentation:

TBD

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jun 20, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 20, 2024
@kron4eg kron4eg mentioned this pull request Jun 20, 2024
Closed
@kron4eg kron4eg force-pushed the new-addons branch 2 times, most recently from ba96124 to 71a9942 Compare June 20, 2024 00:43
@kron4eg kron4eg removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Jun 20, 2024
@kron4eg kron4eg marked this pull request as ready for review June 20, 2024 13:03
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2024
@kron4eg kron4eg requested a review from xmudrii June 24, 2024 08:11
xmudrii
xmudrii requested changes Jul 31, 2024
View reviewed changes
pkg/apis/kubeone/validation/validation_test.go Outdated Show resolved Hide resolved
test/e2e/testdata/containerd_calico_external.yaml Show resolved Hide resolved
pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeone/config/migrate.go Outdated Show resolved Hide resolved
pkg/apis/kubeone/v1beta2/conversion.go Outdated Show resolved Hide resolved
@kron4eg kron4eg marked this pull request as draft July 31, 2024 12:24
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2024
@kron4eg kron4eg force-pushed the new-addons branch 4 times, most recently from b6cc261 to f81aab6 Compare August 5, 2024 16:46
@kron4eg kron4eg requested a review from xmudrii August 5, 2024 16:55
xmudrii
xmudrii requested changes Aug 6, 2024
View reviewed changes
pkg/cmd/config.go Show resolved Hide resolved
pkg/apis/kubeone/config/migrate.go Show resolved Hide resolved
@kron4eg kron4eg mentioned this pull request Aug 6, 2024
Merged
kron4eg added 13 commits August 12, 2024 11:55
@kron4eg
Fix the code after types changes
2370d88 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Automatically convert KubeOneCluster v1beta2 into v1beta3
9b51c34 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Migrate e2e test manifests to v1beta3
6330b42 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Add E2E tests for helm addons
e658000 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Make linter happy
8055477 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Fixes NPE in Addons API
4bca308 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Convert config template from string into embeddable file
3141f9b 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Review changes
6efa92e 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Modernize yamled
13654f0 
* replaced interface{} with any
* replaced long ifs with more readable switches

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
new yamled Document.Walk() method
69075c8 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Framework to free transform YAML
0ef86bc 
* migrate v1beta2 to v1beta3
* fix cosmetic issues

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Fix config print -f
ed4aeeb 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
unittests for MigrateV1beta2V1beta3
ea852ee 
Signed-off-by: Artiom Diomin <[email protected]>
xmudrii
xmudrii approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
:shipit:

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02cd4d341d5f44d96be5a316c69fe0ddcbdfef02

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@kron4eg kron4eg marked this pull request as ready for review August 12, 2024 09:58
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@kron4eg
Copy link
Member Author

kron4eg commented Aug 12, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit 494d081 into kubermatic:main Aug 12, 2024
13 of 14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Aug 12, 2024
@kron4eg kron4eg deleted the new-addons branch August 12, 2024 11:17
@kron4eg kron4eg mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii