-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generate_makefile.bash mentioning #470
Remove generate_makefile.bash mentioning #470
Conversation
This script is not officially supported by us for external users.
For a full list of generate_makefile.bash options use the command | ||
```bash | ||
> ${srcdir}/generate_makefile.bash --help | ||
``` | ||
|
||
### Spack | ||
An alternative to manually building with CMake is to use the Spack package manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe provide a link to Spack ([email protected]:spack/spack.git)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is besides the scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because this PR is about not advertising the generate_makefile.bash
script and it has nothing to do with Spack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this PR is to move people away from Makefile use, and proposing alternatives (e.g., Spack) to CMake manual builds, n'est-ce pas? How would those words sum to an advert for Makefile?
@@ -255,7 +244,6 @@ A word of caution on where to include the `Makefile.kokkos`: since the embedded | |||
|
|||
More example application Makefiles can be found in the tutorial examples under `kokkos/example/tutorial`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't line 245 a bit conflict-y with steering people away from using Makefiles? IOW, don't do anything to encourage it, if that's not what you want users to do.
This script is not officially supported by us for external users.