Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpi: contiguous Irecv wrapper #55

Merged
merged 1 commit into from
May 17, 2024
Merged

mpi: contiguous Irecv wrapper #55

merged 1 commit into from
May 17, 2024

Conversation

cwpearson
Copy link
Collaborator

No description provided.

@cwpearson cwpearson changed the title mpi: basic contiguous Irecv mpi: basic contiguous Irecv wrapper May 13, 2024
@cwpearson cwpearson mentioned this pull request May 13, 2024
Closed
1 task
@cwpearson cwpearson changed the title mpi: basic contiguous Irecv wrapper mpi: contiguous Irecv wrapper May 13, 2024
@cwpearson cwpearson mentioned this pull request May 13, 2024
Open
7 tasks
cedricchevalier19
cedricchevalier19 reviewed May 15, 2024
View reviewed changes
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the API should be improved to be more coherent with isend.

Personally, I find the isend one better.

src/impl/KokkosComm_irecv.hpp Show resolved Hide resolved
unit_tests/test_isendirecv.cpp Show resolved Hide resolved
unit_tests/test_isendirecv.cpp Show resolved Hide resolved
unit_tests/view_builder.hpp Show resolved Hide resolved
@cwpearson cwpearson merged commit aebe2ab into kokkos:develop May 17, 2024
6 checks passed
@cwpearson cwpearson deleted the mpi/irecv-low branch May 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricchevalier19 cedricchevalier19 cedricchevalier19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwpearson @cedricchevalier19