Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicitly test against kokkos master for PR tests #131

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cwpearson
Copy link
Collaborator

@cwpearson cwpearson commented Dec 18, 2024

This way we test against whatever the latest release is, and we can add some nightlies to test against develop

Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it works.

We can also fetch directly the latest tarball, I will give you a one liner for that.

@@ -43,7 +43,7 @@ jobs:
- run: echo "This job's status is ${{ job.status }}."
- name: Build Kokkos
run: |
git clone https://github.com/kokkos/kokkos.git "$KOKKOS_SRC"
git clone https://github.com/kokkos/kokkos.git --branch master "$KOKKOS_SRC"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it is useful as the next line does an explicit git checkout 4.2.00.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants