Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a checklist for tracking conformance tests succeed for each implementation #356

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

carlisia
Copy link
Member

@carlisia carlisia commented Aug 9, 2022

Closes #354

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 9, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@carlisia carlisia changed the title Add a checklist for tracking conformance tests for each implementation Add a checklist for tracking conformance tests succeed for each implementation Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #356 (1b912e8) into main (d100e91) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   16.47%   16.53%   +0.06%     
==========================================
  Files          21       21              
  Lines        3175     3175              
==========================================
+ Hits          523      525       +2     
+ Misses       2621     2619       -2     
  Partials       31       31              
Impacted Files Coverage Δ
pkg/reconciler/ingress/resources/httproute.go 94.77% <0.00%> (+1.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nak3
Copy link
Contributor

nak3 commented Aug 9, 2022

/lgtm
Thank you!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2022
@knative-prow knative-prow bot merged commit 3872b33 into knative-extensions:main Aug 9, 2022
@carlisia carlisia deleted the checklist branch August 9, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a GH checklist template for conformance tests
2 participants