Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/hacky]: Kafka Source tests debugging #3443

Closed

Conversation

Cali0707
Copy link
Member

Proposed Changes

  • Log out more info in the tests

Release Note


Docs

@knative-prow
Copy link

knative-prow bot commented Oct 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2023
@knative-prow knative-prow bot requested review from aliok and lionelvillard October 26, 2023 22:13
@knative-prow knative-prow bot added area/test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@Cali0707
Copy link
Member Author

/test reconciler-tests

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (828b81e) 61.58% compared to head (afb6aa9) 61.58%.
Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3443   +/-   ##
=========================================
  Coverage     61.58%   61.58%           
  Complexity      762      762           
=========================================
  Files           181      181           
  Lines         12405    12405           
  Branches        265      265           
=========================================
  Hits           7640     7640           
  Misses         4163     4163           
  Partials        602      602           
Flag Coverage Δ
java-unittests 70.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member

/test reconciler-tests

@Cali0707
Copy link
Member Author

@pierDipi I think we need to run more of the tests, it seems like the bug doesn't occur when running only KafkaSourceDelete tests

@Cali0707
Copy link
Member Author

/test reconciler-tests

@Cali0707
Copy link
Member Author

/retest

@Cali0707
Copy link
Member Author

/test reconciler-tests

1 similar comment
@pierDipi
Copy link
Member

/test reconciler-tests

Signed-off-by: Calum Murray <[email protected]>
@Cali0707
Copy link
Member Author

/test reconciler-tests

2 similar comments
@Cali0707
Copy link
Member Author

Cali0707 commented Nov 1, 2023

/test reconciler-tests

@Cali0707
Copy link
Member Author

Cali0707 commented Nov 2, 2023

/test reconciler-tests

Signed-off-by: Calum Murray <[email protected]>
@Cali0707
Copy link
Member Author

Cali0707 commented Nov 2, 2023

/test reconciler-tests
/test reconciler-tests-namespaced-broker

Copy link

knative-prow bot commented Nov 2, 2023

@Cali0707: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_eventing-kafka-broker_main bc95f21 link true /test build-tests
reconciler-tests_eventing-kafka-broker_main afb6aa9 link true /test reconciler-tests
reconciler-tests-namespaced-broker_eventing-kafka-broker_main afb6aa9 link true /test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2024
@github-actions github-actions bot closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants