Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the instruction on how to run single rekt test #3407

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Add the instruction on how to run single rekt test #3407

merged 6 commits into from
Nov 17, 2023

Conversation

rajibmitra
Copy link
Contributor

Fixes #3297

Docs
This is Docs PR , added instruction for rekt based test and its parameters.

@knative-prow
Copy link

knative-prow bot commented Oct 17, 2023

Welcome @rajibmitra! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 17, 2023

Hi @rajibmitra. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from aliok and lionelvillard October 17, 2023 20:29
@Cali0707
Copy link
Member

/cc @Leo6Leo

@knative-prow knative-prow bot requested a review from Leo6Leo October 17, 2023 22:14
Leo6Leo
Leo6Leo suggested changes Oct 18, 2023
View reviewed changes
DEVELOPMENT.md Outdated Show resolved Hide resolved
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 18, 2023

/retitle Add the instruction on how to run single rekt test

@rajibmitra rajibmitra changed the title added rekt test and parameters Add the instruction on how to run single rekt test Oct 18, 2023
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 18, 2023

/lgtm
/cc @pierDipi @creydr @Cali0707
Thanks for the contribution and the prompt action! The instructions and explanation you have added is clear and easy to follow. Great job!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 18, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2023
Cali0707
Cali0707 suggested changes Oct 18, 2023
View reviewed changes
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 30, 2023

Heyy @rajibmitra! Are there anything we could help with on this PR?

@rajibmitra rajibmitra requested a review from Cali0707 October 31, 2023 07:35
@rajibmitra
Copy link
Contributor Author

Heyy @rajibmitra! Are there anything we could help with on this PR?

Sorry, I didnt get the notification earlier of these comments, I have incorporated all the review comments, please take a look.

@pierDipi
Copy link
Member

Test failure doesn't seem related
/retest-required

@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (204be08) 61.46% compared to head (8fb45e1) 61.60%.
Report is 38 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3407      +/-   ##
============================================
+ Coverage     61.46%   61.60%   +0.14%     
- Complexity      761      762       +1     
============================================
  Files           181      181              
  Lines         12356    12405      +49     
  Branches        265      265              
============================================
+ Hits           7594     7642      +48     
  Misses         4161     4161              
- Partials        601      602       +1
Flag Coverage Δ
java-unittests 70.94% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cali0707
Cali0707 reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @pierDipi

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@rajibmitra rajibmitra requested a review from Cali0707 November 1, 2023 15:39
@rajibmitra
Copy link
Contributor Author

is there anything left to be done in this PR, please let me know.

@Cali0707
Copy link
Member

Cali0707 commented Nov 2, 2023

Just waiting on an eventing approver to approve this change!

pierDipi
pierDipi approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, rajibmitra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Nov 17, 2023

/retest-required

2 similar comments
@Cali0707
Copy link
Member

/retest-required

@Cali0707
Copy link
Member

/retest-required

@knative-prow knative-prow bot merged commit b8da68a into knative-extensions:main Nov 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo6Leo Leo6Leo Leo6Leo requested changes

@pierDipi pierDipi pierDipi approved these changes

@aliok aliok Awaiting requested review from aliok

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@creydr creydr Awaiting requested review from creydr

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@pierDipi pierDipi

@Leo6Leo Leo6Leo

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the instruction on how to run single rekt test
4 participants
@rajibmitra @Cali0707 @Leo6Leo @pierDipi