Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to latest Quarkus 3.2.x version #3382

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Updating to latest Quarkus 3.2.x version #3382

merged 1 commit into from
Oct 18, 2023

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Oct 9, 2023

Fixes #

  • as per title

Release Note

Docs

@knative-prow knative-prow bot requested review from aliok and Cali0707 October 9, 2023 09:06
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane labels Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #3382 (3e4219b) into main (933098d) will decrease coverage by 9.34%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3382      +/-   ##
============================================
- Coverage     70.88%   61.54%   -9.34%     
  Complexity      762      762              
============================================
  Files            90      181      +91     
  Lines          3077    12322    +9245     
  Branches        265      265              
============================================
+ Hits           2181     7584    +5403     
- Misses          730     4142    +3412     
- Partials        166      596     +430
Flag Coverage Δ
java-unittests 70.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 91 files with indirect coverage changes

@matzew
Copy link
Contributor Author

matzew commented Oct 9, 2023

/retest

@matzew
Copy link
Contributor Author

matzew commented Oct 10, 2023

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Oct 10, 2023

/test channel-integration-tests-sasl-plain

@matzew
Copy link
Contributor Author

matzew commented Oct 10, 2023

/test reconciler-tests-namespaced-broker

2 similar comments
@Cali0707
Copy link
Member

/test reconciler-tests-namespaced-broker

@matzew
Copy link
Contributor Author

matzew commented Oct 13, 2023

/test reconciler-tests-namespaced-broker

pierDipi
pierDipi approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor Author

matzew commented Oct 18, 2023

/test channel-integration-tests-sasl-plain

2 similar comments
@matzew
Copy link
Contributor Author

matzew commented Oct 18, 2023

/test channel-integration-tests-sasl-plain

@matzew
Copy link
Contributor Author

matzew commented Oct 18, 2023

/test channel-integration-tests-sasl-plain

@knative-prow knative-prow bot merged commit 794302d into knative-extensions:main Oct 18, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aliok aliok Awaiting requested review from aliok

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @Cali0707 @pierDipi