Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make skipExitPage and showFooter parameters optional for android #3

Merged
merged 4 commits into from
Jul 31, 2024
Merged

fix: make skipExitPage and showFooter parameters optional for android #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f679a0
fix: make skipExitPage and showFooter parameters optional for android
mc-khipu Jul 31, 2024
381dbbf
fix: changes version of khipuClientIOS in example
mc-khipu Jul 31, 2024
f6baf4b
fix: changes version of khipuClientIOS in example
mc-khipu Jul 31, 2024
c6fe365
fix: update Podfile.lock of the example proyect
edavism Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/khipu/KhipuModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ class KhipuModule(reactContext: ReactApplicationContext) :

options.getString("title")?.let { optionsBuilder.topBarTitle(it) }
options.getString("titleImageUrl")?.let { optionsBuilder.topBarImageUrl(it) }
options.getBoolean("skipExitPage")?.let { optionsBuilder.skipExitPage(it) }
options.getBoolean("showFooter")?.let { optionsBuilder.showFooter(it) }
if (options.hasKey("skipExitPage")) optionsBuilder.skipExitPage(options.getBoolean("skipExitPage"))
if (options.hasKey("showFooter")) optionsBuilder.showFooter(options.getBoolean("showFooter"))
options.getString("locale")?.let { optionsBuilder.locale(it) }
if (options.hasKey("theme")) {
val theme: String = options.getString("theme")!!
Expand Down
10 changes: 5 additions & 5 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ PODS:
- KhenshinProtocol (1.0.44)
- KhenshinSecureMessage (1.3.0):
- KHTweetNacl (= 1.1.4)
- KhipuClientIOS (2.7.1):
- KhipuClientIOS (2.7.2):
- KhenshinProtocol (= 1.0.44)
- KhenshinSecureMessage (= 1.3.0)
- Socket.IO-Client-Swift (= 16.1.0)
Expand Down Expand Up @@ -944,11 +944,11 @@ PODS:
- React-Mapbuffer (0.74.1):
- glog
- React-debug
- react-native-khipu (2.7.0):
- react-native-khipu (2.8.0):
- DoubleConversion
- glog
- hermes-engine
- KhipuClientIOS (= 2.7.1)
- KhipuClientIOS (= 2.7.2)
- RCT-Folly (= 2024.01.01.00)
- RCTRequired
- RCTTypeSafety
Expand Down Expand Up @@ -1392,7 +1392,7 @@ SPEC CHECKSUMS:
hermes-engine: 16b8530de1b383cdada1476cf52d1b52f0692cbc
KhenshinProtocol: 12df55da4968686dfda93a80c3ffcc87de09cc32
KhenshinSecureMessage: f0604e236fe33a3538ee01129c74c94d724bf546
KhipuClientIOS: 851757710903d9bc6cf9ee053707b138f66a9987
KhipuClientIOS: 86685ab2a9be54be9050d39b1b77c158d5b71c4d
KHTweetNacl: 405b98e955a2fdb50eb8372fde9c6b50b218e51b
RCT-Folly: 02617c592a293bd6d418e0a88ff4ee1f88329b47
RCTDeprecation: efb313d8126259e9294dc4ee0002f44a6f676aba
Expand All @@ -1418,7 +1418,7 @@ SPEC CHECKSUMS:
React-jsitracing: 233d1a798fe0ff33b8e630b8f00f62c4a8115fbc
React-logger: 7e7403a2b14c97f847d90763af76b84b152b6fce
React-Mapbuffer: 11029dcd47c5c9e057a4092ab9c2a8d10a496a33
react-native-khipu: e2366677ffdba17d255731a1c8c94e62f5d4d680
react-native-khipu: 029b7a907c3271ef5add00578490ad32f68c28e0
React-nativeconfig: b0073a590774e8b35192fead188a36d1dca23dec
React-NativeModulesApple: df46ff3e3de5b842b30b4ca8a6caae6d7c8ab09f
React-perflogger: 3d31e0d1e8ad891e43a09ac70b7b17a79773003a
Expand Down
Loading