Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing vocabulary publication #44

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Preparing vocabulary publication #44

merged 3 commits into from
Dec 3, 2024

Conversation

elsdvlee
Copy link
Collaborator

@elsdvlee elsdvlee commented Dec 3, 2024

What's changed

Adding labels and comments
Adding metadata
Generating Widoco files
Evaluation with Oops!

Change checklist

  • updated ontology, where necessary
  • updated shapes, where necessary
  • added or updated test cases, where necessary
  • any TODOs have been turned into trackable issues and referenced where necessary

Issue reference

Resolves #41, #42, #43

- Adding label and comment
- Adding metadata
- Generate publication format with Widoco
- Evaluate with Oops!
Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment.

Comment on lines +181 to +182
### http://w3id.org/rml/LogicalIterable
<http://w3id.org/rml/LogicalIterable> rdf:type owl:Class .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be removed, since it will be imported.

Copy link
Collaborator Author

@elsdvlee elsdvlee Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been added by Widoco. It is not there in the original file before Widoco: ontology/ontology.owl

@elsdvlee elsdvlee merged commit 2662894 into main Dec 3, 2024
1 check failed
@elsdvlee elsdvlee deleted the Vocabulary branch December 3, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rdfs:label and rdfs:comment to vocabulary
2 participants