Avoid potential use of dangling temporary objects. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In something like ``` const auto& transformMatrix = detelement.nominal().worldTransformation(); ``` nominal() returns a temporary Alignment object by value, and worldTransformation() returns a reference within that Alignment object. So we should make a copy. (The C++ rules for extending the lifetime of a temporary bound to a reference don't help here because the object bound to a reference is different from the object whose lifetime needs to be extended.)
|
Was this pointed out by a compiler flag / warning or did you get to know about this via some (I would assume non-trivial) debugging)? If the former, we should try to also get that into CI, IMHO. |
|
Newer versions of clang report that, but this is only available in the LCG stacks I think |
|
k4geo should build on an LCG stack, right? It would be nice to avoid re-introducing this in the future. |
|
Yeah, i saw compiler warnings. But i'm doing my own builds outside of the key4hep release, so compiler versions and to some extent compilation flags may be different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In something like
nominal() returns a temporary Alignment object by value, and worldTransformation() returns a reference within that Alignment object. So we should make a copy.
(The C++ rules for extending the lifetime of a temporary bound to a reference don't help here because the object bound to a reference is different from the object whose lifetime needs to be extended.)
BEGINRELEASENOTES
ENDRELEASENOTES